- United States
- https://bancino.net
- Joined on
2024-09-14
d7da8e0a54
Merge pull request 'Fix potential double-free issue in Cytoplasm' (#22) from lda/Cytoplasm:fix-router-issue into master
Either way, I'll merge this for now and then we can make a new pull request for the license text changes.
Short question: should the copyright holders name in the licensed be changed to add something like "with other contributors"?
That's a great question. I haven't given it much thought but it…
Io
Everyone says not to touch crypto, but somebody has to do it, and honestly it isn't that hard. Conceptually it is not difficult to understand, and the specifications are very thorough. There are…
Yeah, I think I agree, that's just going to be a bit more work. Figuring out how to create default objects, for example, will not be trivial.
I will merge it sometime this weekend, I hope. It is my goal to sit down and spend some time with all of your pull requests.
This looks excellent, thank you so much! I was dreading having to go through all of these and do this myself.
HttpRouter: Decode path parts before matching.
I think the decoding should happen before the matching. It would be confusing to match on an encoded path part but then have the decoded part be something totally different. So, we should decode the pathPart before feeding it into regexec(), match on that, and then take the appropriate substring from the decoded path part.
Yeah. I figured this would probably be necessary at some point. Clients don't like to see only v1.7, they like to see all of the preceding versions as well. Maybe we should add v1.2 through v1.6 as well, just for completeness?
Same as above. Cytoplasm should be doing this. If it isn't, then we should open an issue there.