Telodendria/Telodendria
Telodendria
/
Telodendria
3
6
Fork 8
Code Issues 8 Pull Requests 1 Actions Projects 3 Releases 4 Wiki Activity

Set an error message with MatrixErrorCreate whenever applicable #45

Merged
jordan merged 33 commits from lda/telodendria:refactor-matrix-error-create into master 2023-12-02 10:24:11 -05:00
Conversation 2 Commits 33 Files Changed 19 +161 -80
lda commented 2023-12-01 14:57:28 -05:00
Contributor
Copy Link

Effectively implements #6.

Please review the developer certificate of origin:

  1. The contribution was created in whole or in part by me, and I have
    the right to submit it under the open source licenses of the
    Telodendria project; or
  2. The contribution is based upon a previous work that, to the best of
    my knowledge, is covered under an appropriate open source license and
    I have the right under that license to submit that work with
    modifications, whether created in whole or in part by me, under the
    Telodendria project license; or
  3. The contribution was provided directly to me by some other person
    who certified (1), (2), or (3), and I have not modified it.
  4. I understand and agree that this project and the contribution are
    made public and that a record of the contribution—including all
    personal information I submit with it—is maintained indefinitely
    and may be redistributed consistent with this project or the open
    source licenses involved.
  • I have read the Telodendria Project development certificate of
    origin, and I certify that I have permission to submit this patch
    under the conditions specified in it.
Effectively implements #6. --- Please review the developer certificate of origin: 1. The contribution was created in whole or in part by me, and I have the right to submit it under the open source licenses of the Telodendria project; or 1. The contribution is based upon a previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the Telodendria project license; or 1. The contribution was provided directly to me by some other person who certified (1), (2), or (3), and I have not modified it. 1. I understand and agree that this project and the contribution are made public and that a record of the contribution—including all personal information I submit with it—is maintained indefinitely and may be redistributed consistent with this project or the open source licenses involved. - [x] I have read the Telodendria Project development certificate of origin, and I certify that I have permission to submit this patch under the conditions specified in it.
lda added 33 commits 2023-12-01 14:57:28 -05:00
afc9e0e5dc Fixes issue #33 related to a memory issue, and format some code. (#35) 
Fixes #33.

Co-authored-by: LoaD Accumulator <lda@freetards.xyz>
Reviewed-on: Telodendria/telodendria#35
Co-authored-by: LoaD Accumulator <lda@noreply.git.telodendria.io>
Co-committed-by: LoaD Accumulator <lda@noreply.git.telodendria.io>
jordan commented 2023-12-01 20:51:04 -05:00
Owner
Copy Link

This looks excellent, thank you so much! I was dreading having to go through all of these and do this myself.

This looks excellent, thank you so much! I was dreading having to go through all of these and do this myself.
jordan commented 2023-12-01 20:51:25 -05:00
Owner
Copy Link

I will merge it sometime this weekend, I hope. It is my goal to sit down and spend some time with all of your pull requests.

I will merge it sometime this weekend, I hope. It is my goal to sit down and spend some time with all of your pull requests.
jordan merged commit 2c6d5194d2 into master 2023-12-02 10:24:11 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Telodendria/Telodendria#45
No description provided.
Delete Branch "lda/telodendria:refactor-matrix-error-create"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?