Telodendria/Telodendria
Telodendria
/
Telodendria
3
6
Fork 8
Code Issues 8 Pull Requests 1 Actions Projects 3 Releases 4 Wiki Activity

j2s: Unable to set default value of true on booleans #3

New Issue
Closed
opened 2023-09-05 15:58:39 -04:00 by jordan · 4 comments
jordan commented 2023-09-05 15:58:39 -04:00
Owner
Copy Link

Because of the way the generated code works, we can't reliably default a boolean value to true, because both explicitly setting it and leaving it omitted in the JSON will cause the struct value to be false; we can't tell which occurred.

Because of the way the generated code works, we can't reliably default a boolean value to true, because both explicitly setting it and leaving it omitted in the JSON will cause the struct value to be false; we can't tell which occurred.
jordan added the
enhancement
 label 2023-09-05 15:58:39 -04:00
jordan commented 2023-09-05 16:02:25 -04:00
Author
Owner
Copy Link

We could just set boolean fields to -1 when they aren't specified. Then higher-level code can set the appropriate value from there, but buggy code may blindly check the boolean and see that -1 evaluates to true and thus behave in an unexpected manner.

The other solution is to add support for setting default values at the parser level.

We could just set boolean fields to `-1` when they aren't specified. Then higher-level code can set the appropriate value from there, but buggy code may blindly check the boolean and see that `-1` evaluates to true and thus behave in an unexpected manner. The other solution is to add support for setting default values at the parser level.
jordan added this to the (deleted) milestone 2023-09-05 16:16:58 -04:00
jordan added this to the Telodendria v1.7.0-alpha4 project 2023-09-05 16:18:04 -04:00
lda commented 2023-12-02 15:58:23 -05:00
Contributor
Copy Link

The other solution is to add support for setting default values at the parser level.

I think that would be the better solution here(removing non-generated initialization code for example).

> The other solution is to add support for setting default values at the parser level. I think that would be the better solution here(removing non-generated initialization code for example).
jordan commented 2023-12-05 07:59:20 -05:00
Author
Owner
Copy Link

Yeah, I think I agree, that's just going to be a bit more work. Figuring out how to create default objects, for example, will not be trivial.

Yeah, I think I agree, that's just going to be a bit more work. Figuring out how to create default objects, for example, will not be trivial.
jordan commented 2024-01-11 19:41:47 -05:00
Author
Owner
Copy Link

Moved to Telodendria/Cytoplasm#26.

Moved to Telodendria/Cytoplasm#26.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Telodendria-0_3_0
Telodendria-0_2_1
Telodendria-0_2_0
Telodendria-0_1_0
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Telodendria v1.7.0-alpha4
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Telodendria/Telodendria#3
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?