j2s: Unable to set default value of true on booleans #3

New Issue

jordan · 2023-09-05T15:58:39-04:00

jordan commented

2023-09-05 15:58:39 -04:00

Because of the way the generated code works, we can't reliably default a boolean value to true, because both explicitly setting it and leaving it omitted in the JSON will cause the struct value to be false; we can't tell which occurred.

jordan added the

enhancement

label 2023-09-05 15:58:39 -04:00

jordan commented

2023-09-05 16:02:25 -04:00

We could just set boolean fields to -1 when they aren't specified. Then higher-level code can set the appropriate value from there, but buggy code may blindly check the boolean and see that -1 evaluates to true and thus behave in an unexpected manner.

The other solution is to add support for setting default values at the parser level.

We could just set boolean fields to `-1` when they aren't specified. Then higher-level code can set the appropriate value from there, but buggy code may blindly check the boolean and see that `-1` evaluates to true and thus behave in an unexpected manner. The other solution is to add support for setting default values at the parser level.

jordan added this to the (deleted) milestone 2023-09-05 16:16:58 -04:00

jordan added this to the Telodendria v1.7.0-alpha4 project 2023-09-05 16:18:04 -04:00

jordan added the

Cytoplasm

label 2023-09-05 16:26:40 -04:00

lda commented

2023-12-02 15:58:23 -05:00

The other solution is to add support for setting default values at the parser level.

I think that would be the better solution here(removing non-generated initialization code for example).

> The other solution is to add support for setting default values at the parser level. I think that would be the better solution here(removing non-generated initialization code for example).

Sign in to join this conversation.