Implement #22 and #9 #44

lda · 2023-11-29T22:17:42Z

lda commented

2023-11-29 22:17:42 +00:00

Implements the following in #22:

RouteRoomAliases
- Get from "id" in aliases
- Note to check permissions according to spec
  - It's still not enough(it only really checks if whenever the user has the ALIAS privilege), but I feel like this should just be left as a TODO until proper room support.
RouteAliasDirectory
- Add "id" objects when putting aliases
- Delete from "id" when deleting aliases

Implements #9 for the user parsing

Please review the developer certificate of origin:

The contribution was created in whole or in part by me, and I have
the right to submit it under the open source licenses of the
Telodendria project; or
The contribution is based upon a previous work that, to the best of
my knowledge, is covered under an appropriate open source license and
I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
Telodendria project license; or
The contribution was provided directly to me by some other person
who certified (1), (2), or (3), and I have not modified it.
I understand and agree that this project and the contribution are
made public and that a record of the contribution—including all
personal information I submit with it—is maintained indefinitely
and may be redistributed consistent with this project or the open
source licenses involved.

I have read the Telodendria Project development certificate of
origin, and I certify that I have permission to submit this patch
under the conditions specified in it.

Implements the following in #22: - `RouteRoomAliases` - [x] Get from "id" in aliases - [x] Note to check permissions according to spec - It's *still* not enough(it only really checks if whenever the user has the `ALIAS` privilege), but I feel like this should just be left as a TODO until proper room support. - `RouteAliasDirectory` - [x] Add "id" objects when putting aliases - [x] Delete from "id" when deleting aliases Implements #9 for the user parsing --- Please review the developer certificate of origin: 1. The contribution was created in whole or in part by me, and I have the right to submit it under the open source licenses of the Telodendria project; or 1. The contribution is based upon a previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the Telodendria project license; or 1. The contribution was provided directly to me by some other person who certified (1), (2), or (3), and I have not modified it. 1. I understand and agree that this project and the contribution are made public and that a record of the contribution—including all personal information I submit with it—is maintained indefinitely and may be redistributed consistent with this project or the open source licenses involved. - [x] I have read the Telodendria Project development certificate of origin, and I certify that I have permission to submit this patch under the conditions specified in it.

jordan reviewed 2023-11-30 12:57:35 +00:00

src/Routes/RouteAliasDirectory.c Outdated

					
				@ -32,3 +36,3 @@

				{

				    RouteArgs *args = argp;

				    char *alias = ArrayGet(path, 0);

				    char *alias = HttpUrlDecode(ArrayGet(path, 0));

jordan commented

2023-11-30 12:57:35 +00:00

I am fairly certain that parameters should already be decoded by the time they are added to the path array. If they aren't, then Cytoplasm needs to do this, not each of the individual routes.

I am fairly certain that parameters should already be decoded by the time they are added to the `path` array. If they aren't, then Cytoplasm needs to do this, not each of the individual routes.

lda commented

2023-11-30 13:59:32 +00:00

Yeah, Cytoplasm doesn't seem to decode those by default it seems...

lda commented

2023-11-30 17:48:58 +00:00

Just filed a short PR to fix that in Cytoplasm(#19).

lda marked this conversation as resolved

jordan reviewed 2023-11-30 12:59:17 +00:00

src/Routes/RouteRoomAliases.c Outdated

					
				@ -30,3 +35,3 @@

				{

				    RouteArgs *args = argp;

				    char *roomId = ArrayGet(path, 0);

				    char *roomId = HttpUrlDecode(ArrayGet(path, 0));

jordan commented

2023-11-30 12:59:17 +00:00

Same as above. Cytoplasm should be doing this. If it isn't, then we should open an issue there.

Same as above. Cytoplasm *should* be doing this. If it isn't, then we should open an issue there.

lda marked this conversation as resolved

jordan reviewed 2023-11-30 13:00:29 +00:00

src/Routes/RouteVersions.c Outdated

					
				@ -37,6 +37,7 @@ ROUTE_IMPL(RouteVersions, path, argp)

				#define DECLARE_SPEC_VERSION(x) ArrayAdd(versions, JsonValueString(x))

				    DECLARE_SPEC_VERSION("v1.5");

jordan commented

2023-11-30 13:00:29 +00:00

Yeah. I figured this would probably be necessary at some point. Clients don't like to see only v1.7, they like to see all of the preceding versions as well. Maybe we should add v1.2 through v1.6 as well, just for completeness?

Yeah. I figured this would probably be necessary at some point. Clients don't like to see only `v1.7`, they like to see all of the preceding versions as well. Maybe we should add `v1.2` through `v1.6` as well, just for completeness?

lda commented

2023-11-30 14:07:40 +00:00

Yeah, just pushed some changes to declare v1.2-v1.7.

Yeah, just pushed some changes to declare `v1.2`-`v1.7`.

lda marked this conversation as resolved

jordan referenced this pull request from Telodendria/Cytoplasm

2023-11-30 19:01:44 +00:00

HttpRouter: Decode path parts before matching. #19

jordan referenced this pull request from a commit

2023-12-02 15:25:30 +00:00

`HttpRouter`: Decode path parts before matching. (#19)

lda changed title from ~~WIP: Implement #22 and #9~~ to Implement #22 and #9