HttpRouter: Decode path parts before matching. #19

lda · 2023-11-30T17:45:23Z

lda commented

2023-11-30 17:45:23 +00:00

Required by Telodendria/Telodendria#44.

lda added 1 commit 2023-11-30 17:45:23 +00:00

[MOD] Encode parameters properly. bca94c0309

jordan reviewed 2023-11-30 18:12:52 +00:00

src/HttpRouter.c Outdated

					
				@ -267,3 +268,3 @@

				                    }

				                    ArrayAdd(matches, substr);

				                    ArrayAdd(matches, HttpUrlDecode(substr));

jordan commented

2023-11-30 18:12:52 +00:00

I think the decoding should happen before the matching. It would be confusing to match on an encoded path part but then have the decoded part be something totally different. So, we should decode the pathPart before feeding it into regexec(), match on that, and then take the appropriate substring from the decoded path part.

I think the decoding should happen *before* the matching. It would be confusing to match on an encoded path part but then have the decoded part be something totally different. So, we should decode the `pathPart` before feeding it into `regexec()`, match on that, and then take the appropriate substring from the decoded path part.

lda commented

2023-11-30 18:19:58 +00:00

Fixed!

lda marked this conversation as resolved

lda added 1 commit 2023-11-30 18:19:43 +00:00

[FIX] Decode pathPart instead of substr itself. fb8ec5f3ae