Telodendria/Telodendria
Telodendria/Telodendria
3
7
Fork 10
Code Issues 8 Pull requests 1 Projects 3 Releases 4 Wiki Activity Actions

Fixes issue #33 related to a memory issue, and format some code. #35

Merged
jordan merged 8 commits from lda/telodendria:fix-33 into master 2023-09-11 14:57:19 +00:00
Conversation 1 Commits 8 Files changed 3 +10 -4
lda commented 2023-09-11 14:40:14 +00:00
Contributor
Copy link

Fixes #33.

Please review the developer certificate of origin:

  1. The contribution was created in whole or in part by me, and I have
    the right to submit it under the open source licenses of the
    Telodendria project; or
  2. The contribution is based upon a previous work that, to the best of
    my knowledge, is covered under an appropriate open source license and
    I have the right under that license to submit that work with
    modifications, whether created in whole or in part by me, under the
    Telodendria project license; or
  3. The contribution was provided directly to me by some other person
    who certified (1), (2), or (3), and I have not modified it.
  4. I understand and agree that this project and the contribution are
    made public and that a record of the contribution—including all
    personal information I submit with it—is maintained indefinitely
    and may be redistributed consistent with this project or the open
    source licenses involved.
  • I have read the Telodendria Project development certificate of
    origin, and I certify that I have permission to submit this patch
    under the conditions specified in it.
Fixes #33. --- Please review the developer certificate of origin: 1. The contribution was created in whole or in part by me, and I have the right to submit it under the open source licenses of the Telodendria project; or 1. The contribution is based upon a previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the Telodendria project license; or 1. The contribution was provided directly to me by some other person who certified (1), (2), or (3), and I have not modified it. 1. I understand and agree that this project and the contribution are made public and that a record of the contribution—including all personal information I submit with it—is maintained indefinitely and may be redistributed consistent with this project or the open source licenses involved. - [x] I have read the Telodendria Project development certificate of origin, and I certify that I have permission to submit this patch under the conditions specified in it.
lda added 6 commits 2023-09-11 14:40:18 +00:00 
Still as WIP as the original however!
Oops, how did I *not* catch this?
Still as WIP as the original however!
lda added 1 commit 2023-09-11 14:42:08 +00:00
lda added 1 commit 2023-09-11 14:43:38 +00:00
jordan reviewed 2023-09-11 14:50:08 +00:00
Cytoplasm/src/HttpRouter.c
@ -197,3 +197,3 @@
char *tmp;
HttpRouteFunc *exec = NULL;
Array *matches;
Array *matches = NULL;
jordan commented 2023-09-11 14:50:08 +00:00
Owner
Copy link

Good catch. At first this doesn't seem necessary, but actually it is because of the finish label, which can be reached before matches is assigned and Free()s it.

Good catch. At first this doesn't seem necessary, but actually it is because of the `finish` label, which can be reached before `matches` is assigned and `Free()`s it.
jordan reviewed 2023-09-11 14:51:22 +00:00
src/Routes/RouteUserProfile.c
@ -175,1 +175,3 @@
Free(username);
/* Username is handled by the router, freeing it *will* cause issues
* (see #33). I honestly don't know how it didn't come to bite us sooner.
jordan commented 2023-09-11 14:51:22 +00:00
Owner
Copy link

Yeah, same. Incredible.

Yeah, same. Incredible.
jordan changed title from WIP: Fixes issue #33 related to a memory issue, and format some code. to Fixes issue #33 related to a memory issue, and format some code. 2023-09-11 14:56:25 +00:00
jordan merged commit 0172fa083b into master 2023-09-11 14:57:19 +00:00
jordan commented 2023-09-11 14:57:53 +00:00
Owner
Copy link

In the future, don't forget to add a change log entry for this kind of stuff!

In the future, don't forget to add a change log entry for this kind of stuff!
jordan referenced this pull request from a commit 2023-09-11 15:01:52 +00:00
Add change log entry for #35.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Telodendria/Telodendria#35
No description provided.
Delete branch "lda/telodendria:fix-33"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?