C99 Compliance #29

Merged

jordan merged 11 commits from c99 into master 2024-01-13 22:13:46 +00:00

Conversation 0 Commits 11 Files changed 40 +384 -1667

jordan commented 2024-01-13 22:13:16 +00:00

Owner

Copy link

This pull request brings Cytoplasm up from C89 to C99, which makes it much more portable across platforms. In particular, this pull request solves a number of issues with 32-bit platforms.

Closes #28.
Closes #12.
Closes #20.

This pull request brings Cytoplasm up from C89 to C99, which makes it much more portable across platforms. In particular, this pull request solves a number of issues with 32-bit platforms. Closes #28. Closes #12. Closes #20.

jordan added 11 commits 2024-01-13 22:13:17 +00:00

Use POSIX c99 and pass -std=c99 just to be safe. 6750134adc

Remove Int, Int64, and UInt64 headers + code. ... 25ccf339fc

Also refactored the existing code to make use of stdint.h and
stdbool.h.

Refactor UtilServerTs() -> UtilTsMillis(). ... f2e8334faf

The old name was a remnant from when Cytoplasm was still a part of
Telodendria, a *server*. Since Cytoplasm is no longer strictly a server
support library, this function name doesn't make sense.

Fix compiler warnings in Sha1.c. ... 846e50a76e

These warnings are false positives emitted by GCC; there are no errors
in the code. By changing the parameter type to a pointer, we prevent
GCC from making faulty assumptions about the code.

Don't use c99 -MM -MT. ... aa737a2b2e

These are non-POSIX flags that only work on some compilers. Notably,
the BSD c99 executables don't support them.

Dependencies must start with ${SRC}/. c693ab0a6a

Detect "fancy" compilers that support more flags. ... 40a9c089ee

We now default to only specifying POSIX compiler flags to maintain
portability, unless a "fancy" compiler is detected that supports
additional flags.

Clean up some simple warnings in Clang. 20fa6816de

Fix compiler warnings on 32-bit systems. b5bc3e54a4

Use 'bool' instead of 'int' wherever semantically correct. e413092a54

Version is now set in src/include/Cytoplasm.h. bc54f0ebfb

jordan merged commit 662696ce12 into master 2024-01-13 22:13:46 +00:00

jordan deleted branch c99 2024-01-13 22:13:48 +00:00

jordan referenced this pull request from a commit 2024-01-13 22:13:48 +00:00

C99 Compliance (#29)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Telodendria/Cytoplasm#29

No description provided.