GCC Compiler Warnings in `Util` #20

New issue

Closed

opened 2023-12-02 02:04:57 +00:00 by uis · 0 comments

uis commented

2023-12-02 02:04:57 +00:00

GCC 12, ARMv7a.

src/Util.c:84:36: warning: right shift count >= width of type [-Wshift-count-overflow]

   84 |         UInt32 high = (UInt32) (ms >> 32);

Same for line 115.

src/Util.c:212:46: warning: left shift count >= width of type [-Wshift-count-overflow]
  212 |         ts.tv_sec = ((time_t) UInt64High(ms) << 32 | UInt64Low(ms)) / 1000;

Shouldn't shift left and or replaced with 64-bin macros?

As I understand time_t is defined as 32-bit variable.

GCC 12, ARMv7a. ``` src/Util.c:84:36: warning: right shift count >= width of type [-Wshift-count-overflow] 84 | UInt32 high = (UInt32) (ms >> 32); ``` Same for line 115. ``` src/Util.c:212:46: warning: left shift count >= width of type [-Wshift-count-overflow] 212 | ts.tv_sec = ((time_t) UInt64High(ms) << 32 | UInt64Low(ms)) / 1000; ``` Shouldn't shift left and or replaced with 64-bin macros? As I understand time_t is defined as 32-bit variable.