lda/telodendria
lda
/
telodendria
forked from Telodendria/Telodendria
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Convert RegTokenInfo to a j2s Schema. #1

Closed
jordan wants to merge 14 commits from Telodendria:pull-37 into implement-26
pull from: Telodendria:pull-37
merge into: lda:implement-26
Conversation 4 Commits 14 Files Changed 16 +306 -222
jordan commented 2023-11-06 15:27:23 -05:00
First-time contributor
Copy Link

This is what I had in mind for RegTokenInfo.

Please give it a look over, making any changes you see fit and merging it when you're ready. When you merge this, I can merge the upstream pull request.

This is what I had in mind for `RegTokenInfo`. Please give it a look over, making any changes you see fit and merging it when you're ready. When you merge this, I can merge the upstream pull request.
lda was assigned by jordan 2023-11-06 15:27:24 -05:00
jordan added 1 commit 2023-11-06 15:27:24 -05:00
jordan commented 2023-11-06 15:33:09 -05:00
Author
First-time contributor
Copy Link

Note: You will need the latest Cytoplasm for this to work properly.

**Note:** You will need the latest Cytoplasm for this to work properly.
lda commented 2023-11-07 01:23:53 -05:00
Owner
Copy Link

That looks good, but the new schema looks like it's missing from the pull request now.

That looks good, but the new schema looks like it's missing from the pull request now.
jordan added 1 commit 2023-11-07 08:08:47 -05:00
jordan added 2 commits 2023-11-08 09:12:33 -05:00
jordan commented 2023-11-08 09:21:13 -05:00
Author
First-time contributor
Copy Link

I fixed some leaks and the segfaulting, but I am still dealing with one other issue with UserEncodePrivileges() and how it is used.

I fixed some leaks and the segfaulting, but I am still dealing with one other issue with `UserEncodePrivileges()` and how it is used.
jordan added 1 commit 2023-11-08 09:34:46 -05:00
jordan added 2 commits 2023-11-08 09:57:18 -05:00
80db737a28 Make RegToken.grants a JSON array. 
It isn't every touched by anything other than UserDecodePrivileges() and UserEncodePrivileges().
jordan added 4 commits 2023-11-08 10:33:59 -05:00
jordan added 1 commit 2023-11-08 12:36:06 -05:00
f87cce0f4c Clean up behavior of RouteAdminTokens(). 
This makes it accept keys with the same names as what is returned back to the caller,
allowing for a more consistent experience.
jordan added 1 commit 2023-11-08 13:42:44 -05:00
jordan added 1 commit 2023-11-08 13:44:20 -05:00
jordan commented 2023-11-08 13:52:40 -05:00
Author
First-time contributor
Copy Link

I'm closing this because my changes to your branch have differed substantially. Future discussion should happen on Telodendria/Telodendria#43.

I'm closing this because my changes to your branch have differed substantially. Future discussion should happen on Telodendria/Telodendria#43.
jordan closed this pull request 2023-11-08 13:52:40 -05:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
lda
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lda/telodendria#1
No description provided.
Delete Branch "Telodendria:pull-37"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?