Copy filename into preallocated field with Cytoplasm's Memory API #33

lda · 2024-05-26T16:04:11-04:00

lda commented

2024-05-26 16:04:11 -04:00

This exists because there does exist scenarios where a const char * may be invalidated during, for example, a memory leak report(especially when shared libraries are involved).

This exists because there **does** exist scenarios where a `const char *` may be invalidated during, for example, a memory leak report(especially when shared libraries are involved).

lda added 1 commit 2024-05-26 16:04:12 -04:00

cdf4430a9e [FIX] Fix issue with const strings which may be invalidated

lda changed title from ~~Copy filename into preallocated field with Cytoplasm's Memory API~~ to WIP: Copy filename into preallocated field with Cytoplasm's Memory API

2024-05-26 16:04:31 -04:00

lda added 1 commit 2024-05-26 16:07:01 -04:00

138ea1c8e9 [FIX] Oops.

lda changed title from ~~WIP: Copy filename into preallocated field with Cytoplasm's Memory API~~ to Copy filename into preallocated field with Cytoplasm's Memory API

2024-05-26 16:07:15 -04:00

jordan commented

2024-05-26 16:32:34 -04:00

The logic and the code is sound, but I do have some concerns with the memory footprint this is going to add. Now every single allocation is 256 bytes bigger? I’ll have to think about how I want to approach this.

jordan referenced this pull request

2024-05-27 17:18:06 -04:00

NULL-Terminated Strings #4

jordan commented

2024-05-27 17:19:49 -04:00

As I mentioned in the Matrix room the other day, this adds a lot of memory overhead, because every single allocation (every single call to Malloc() is now 256 bytes bigger, and while that might not seem like a lot, it will certainly add up in large, complex programs like Telodendria. I made a comment on #4 about string interning; I think if we could intern strings so that only one copy is stored in memory, that would be an acceptable alternative here.

I'm not exactly sure how to go about this, but I'm going to think about it for a little.

As I mentioned in the Matrix room the other day, this adds a *lot* of memory overhead, because every single allocation (every single call to `Malloc()` is now 256 bytes bigger, and while that might not seem like a lot, it will certainly add up in large, complex programs like Telodendria. I made a comment on #4 about string interning; I think if we could intern strings so that only one copy is stored in memory, that would be an acceptable alternative here. I'm not exactly sure how to go about this, but I'm going to think about it for a little.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

You can also view command line instructions.