- United States
- https://bancino.net
- Joined on
2024-09-14
(we really need CI back, don't we?)
Yes we do! I promise I'm working on this... my server infrastructure has been undergoing lots of changes to make this easier.
I'm not sure where we left this but I think it looks okay from my quick glance.
Wow, great work. I understand that the code is still very incomplete and messy, but you've contributed a lot and that's something to be proud of. Just let me know when you're happy with this and…
Can you give some sort of rationale statement for this? I'm not opposed to it, and if you say it works I can go ahead and merge it, but a little comment here as to why this is necessary might be…
39c25e5a17
Merge pull request 'Copy filename into preallocated field with Cytoplasm's Memory API' (#33) from lda/Cytoplasm:direct-filenames into master
After further consideration, this is probably fine. If people complain that Cytoplasm uses too much memory, we can re-evaluate, but I'm okay with this for now.
The code looks good, I'll have to find the time to go through it more to see if it's something we want to merge. I'll have to decide if the functionality we're losing can be implemented in any…
Faster, yes, probably.
More secure, probably not. It's just an algorithm. Unless I didn't implement it properly, it should be just as secure as the TLS library's. Anyone can audit the code if…
That's a very good observation. Wouldn't it be easier if we just pass the length (or type as a constant, like SHA_SHA1 or SHA_SHA256 as a parameter to ShaToHex()? Something like this:
`Sha…
4903c075e8
Merge pull request 'Pre-emptively free out the key' (#41) from lda/Cytoplasm:hashmap-del-leak into master
c3646294f5
Merge pull request 'Fix HTTP header leakage' (#39) from lda/Cytoplasm:fix-duplicate-leak into master