Jordan Bancino jordan
1 follower · 0 following
Repositories
5
 Projects Packages Public activity Starred repositories
jordan pushed to master at Telodendria/Telodendria 2023-09-25 20:11:14 +00:00
7d3d84d969 Move Admin routes to /_telodendria/admin/v1 (with version number)
jordan closed issue Telodendria/Telodendria#16 2023-09-25 20:11:14 +00:00
Administrator API Version Numbers
jordan pushed to master at Telodendria/Telodendria 2023-09-25 20:02:40 +00:00
bf1ce839d0 If HOST_NAME_MAX is undefined, use _POSIX_HOST_NAME_MAX.
jordan closed issue Telodendria/Telodendria#2 2023-09-25 20:02:39 +00:00
NetBSD: HOST_NAME_MAX Not Defined
jordan pushed to master at Telodendria/Telodendria 2023-09-25 19:59:24 +00:00
f8d3e54fec Use int instead of char in EvalExpr.
jordan closed issue Telodendria/Telodendria#5 2023-09-25 19:59:23 +00:00
tp: EvalExpr uses char instead of int
jordan closed issue Telodendria/Telodendria#27 2023-09-25 13:40:14 +00:00
Admin API for Deactivating and Reactivating Local Users
jordan pushed to master at Telodendria/Telodendria 2023-09-25 13:39:25 +00:00
cb41716bf3 Implement #27 (#36)
jordan merged pull request Telodendria/Telodendria#36 2023-09-25 13:39:25 +00:00
Implement #27
jordan commented on pull request Telodendria/Telodendria#36 2023-09-25 13:38:42 +00:00
Implement #27

Oh nevermind, I see that the default behavior of this function is to set it to the user's own name.

jordan commented on pull request Telodendria/Telodendria#36 2023-09-25 13:37:22 +00:00
Implement #27

I think we should set these parameters instead of having them be NULL. The from should be the user, and the reason can just be hard-coded if necessary.

jordan commented on pull request Telodendria/Telodendria#36 2023-09-21 13:59:31 +00:00
Implement #27

Fair enough, I'm good with that. It doesn't look bad by any means, the code is still readable. Everyone has their own style and I have no real problems with this one.

jordan commented on pull request Telodendria/Telodendria#36 2023-09-20 20:02:18 +00:00
Implement #27

This looks pretty good. I will read the code more closely and test it when I have time. In the meantime, take a look at my comments and see what you feel is relevant. If you disagree with…

jordan commented on pull request Telodendria/Telodendria#36 2023-09-20 19:59:36 +00:00
Implement #27

Is a separate function really necessary? Shouldn't we just modify UserDeactivate() to take the additional params?

jordan commented on pull request Telodendria/Telodendria#36 2023-09-20 19:57:52 +00:00
Implement #27

Again, why use an intermediate variable here?

jordan commented on pull request Telodendria/Telodendria#36 2023-09-20 19:53:11 +00:00
Implement #27

Is there a reason for declaring a variable here instead of just passing the string literal into MatrixErrorCreate()?

jordan commented on pull request Telodendria/Telodendria#36 2023-09-20 19:51:37 +00:00
Implement #27

Same as above.

jordan commented on pull request Telodendria/Telodendria#36 2023-09-20 19:51:19 +00:00
Implement #27

This shouldn't be necessary. It should suffice to just UserUnlock() here without first checking for NULL, because UserUnlock() should have a NULL check in it already. I am going off of memory on that one, but if I'm wrong, UserUnlock() should have this check instead.

jordan commented on issue Telodendria/Telodendria#2 2023-09-20 19:47:41 +00:00
NetBSD: HOST_NAME_MAX Not Defined

Interesting. Let's take a look at the official POSIX standard: https://bancino.net/mirror/susv4-2018/basedefs/limits.h.html. It appears that HOST_NAME_MAX is a runtime invariant that may be…

jordan commented on issue Telodendria/Telodendria#13 2023-09-11 20:16:35 +00:00
Refactor Memory API to use mmap() syscall.

Good point. And honestly, this is kind of more wishful thinking for the time being, I might not ever actually get around to doing this. The current method is at no risk of going away any time…