Telodendria/Cytoplasm
Telodendria/Cytoplasm
3
3
Fork 5
Code Issues 17 Pull requests 2 Projects Releases 2 Packages Activity Actions

WIP: Rework logging #48

Draft
Levitating wants to merge 2 commits from Levitating/Cytoplasm:log into master
pull from: Levitating/Cytoplasm:log
merge into: Telodendria:master
Conversation 2 Commits 2 Files changed 2 +1 -2
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ba450ee766 - Show all commits

3
src/Log.c
View file

@ -26,7 +26,6 @@
#include <Memory.h> #include <Memory.h>
#include <Util.h> #include <Util.h>
#include <cstdarg>
#include <string.h> #include <string.h>
Levitating marked this conversation as resolved Outdated
lda commented 2024-08-25 23:08:13 +00:00
Outdated
Review
Copy link

I think you meant stdarg.h, as those kind of includes are C++isms.

I think you meant stdarg.h, as those kind of includes are C++isms.
Levitating commented 2024-08-26 17:45:34 +00:00
Outdated
Review
Copy link

It was most likely automatically added by my IDE by accident.

It was most likely automatically added by my IDE by accident.
#include <time.h> #include <time.h>
#include <unistd.h> #include <unistd.h>
@ -222,7 +221,7 @@ LogConfigUnindent(LogConfig * config)
} }
} }
void static void
LogPrint(Stream * stream, LogConfig * config, int level, const char *msg, va_list argp) LogPrint(Stream * stream, LogConfig * config, int level, const char *msg, va_list argp)
Levitating marked this conversation as resolved Outdated
lda commented 2024-08-25 23:13:44 +00:00
Outdated
Review
Copy link

I'd probably consider making LogPrint static here, as it's not even part of the public includes.

I'd probably consider making LogPrint static here, as it's not even part of the public includes.
Levitating commented 2024-08-26 17:45:04 +00:00
Outdated
Review
Copy link

Yes it should be static!

Yes it should be static!
{ {
size_t i; size_t i;