Telodendria/Cytoplasm
Telodendria/Cytoplasm
3
3
Fork 4
Code Issues 13 Pull requests 2 Projects Releases 2 Packages Activity Actions

Start optionally using the SHA implementation from the existing crypto API #44

Merged
jordan merged 5 commits from lda/Cytoplasm:opt-ssl-for-sha into master 2024-08-24 17:06:05 +00:00
Conversation 1 Commits 5 Files changed 2 +4 -2
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 7752ea7b86 - Show all commits

3
src/Sha/Sha1.c
View file

@ -28,7 +28,8 @@
#include <limits.h>
#if (TLS_IMPL == TLS_OPENSSL) || (TLS_IMPL == TLS_LIBRESSL)
/* TODO: Verify LibreSSL support later */
lda marked this conversation as resolved Outdated
jordan commented 2024-08-23 20:22:15 +00:00
Outdated
Review
Copy link

If you just say #if (TLS_IMPL == TLS_OPENSSL) and get rid of the LibreSSL check, then this will only be applied with OpenSSL, which you verified to work. We can then merge this and add back LibreSSL support later after we verify it is working.

If you just say `#if (TLS_IMPL == TLS_OPENSSL)` and get rid of the LibreSSL check, then this will only be applied with OpenSSL, which you verified to work. We can then merge this and add back LibreSSL support later after we verify it is working.
#if TLS_IMPL == TLS_OPENSSL
#include <openssl/sha.h>

3
src/Sha/Sha256.c
View file

@ -30,7 +30,8 @@
#include <limits.h>
#if (TLS_IMPL == TLS_OPENSSL) || (TLS_IMPL == TLS_LIBRESSL)
/* TODO: Verify LibreSSL support later */
#if TLS_IMPL == TLS_OPENSSL
#include <openssl/sha.h>