curl refuses to fetch from HttpServer without --http0.9 #57

New issue

Closed

opened 2024-10-11 13:59:08 +00:00 by tobskep · 3 comments

tobskep commented

2024-10-11 13:59:08 +00:00

I'm trying to rewrite one of my ongoing web projects in C using Cytoplasm. I've created an HTTP server and started it. It echoes the path requested back at the user.

I've noticed a problem with curl where if you don't pass the argument --http0.9, it refuses to download with the following message:

curl: (1) Received HTTP/0.9 when not allowed

When you pass --http0.9, it successfully fetches. What gives?

Here is the full program source, for debuggery:

void Handler(HttpServerContext *ctx, void *argv) {
    char* path = HttpRequestPath(ctx);
    Stream* out = HttpServerStream(ctx);

    HttpResponseStatus(ctx, HTTP_OK);
    HttpResponseHeader(ctx, "Content-type", "text/plain");
    StreamPrintf(out, "Everything is OK\nPath: %s\n", path);

    return;
}
int Main(Array *args, HashMap *envs) {
    // create HTTP server
    HttpServerConfig cfg = {
        6750,
        100,
        100,
        HTTP_FLAG_NONE,
        NULL, NULL,
        Handler,
        NULL
    };
    HttpServer *server = HttpServerCreate(&cfg);
    
    if (HttpServerStart(server) == false) {
        Log(LOG_ERR, "Failed to start HTTP server! (%s)", strerror(errno));
        return 1;
    } else {
        Log(LOG_INFO, "Started HTTP server on port %d.", cfg.port);
        HttpServerJoin(server);
        return 0;
    }
}

I'm trying to rewrite one of my ongoing web projects in C using Cytoplasm. I've created an HTTP server and started it. It echoes the path requested back at the user. I've noticed a problem with `curl` where if you don't pass the argument `--http0.9`, it refuses to download with the following message: ``` curl: (1) Received HTTP/0.9 when not allowed ``` When you pass `--http0.9`, it successfully fetches. What gives? Here is the full program source, for debuggery: ``` void Handler(HttpServerContext *ctx, void *argv) { char* path = HttpRequestPath(ctx); Stream* out = HttpServerStream(ctx); HttpResponseStatus(ctx, HTTP_OK); HttpResponseHeader(ctx, "Content-type", "text/plain"); StreamPrintf(out, "Everything is OK\nPath: %s\n", path); return; } int Main(Array *args, HashMap *envs) { // create HTTP server HttpServerConfig cfg = { 6750, 100, 100, HTTP_FLAG_NONE, NULL, NULL, Handler, NULL }; HttpServer *server = HttpServerCreate(&cfg); if (HttpServerStart(server) == false) { Log(LOG_ERR, "Failed to start HTTP server! (%s)", strerror(errno)); return 1; } else { Log(LOG_INFO, "Started HTTP server on port %d.", cfg.port); HttpServerJoin(server); return 0; } } ```

tobskep commented

2024-10-11 14:43:44 +00:00

Author

Turns out it was my code. Still wouldn't mind knowing what caused that? That's a weird failure mode

tobskep closed this issue

2024-10-11 14:43:44 +00:00

lda commented

2024-10-11 14:49:31 +00:00

Contributor

Still wouldn't mind knowing what caused that? That's a weird failure mode
Probably due to the fact you didnt call HttpSendHeaders (which caused curl to get really confused when it didnt get any data)
I think Cytoplasm should be made to warn/auto-send when that happens but you could argue that being able to use the stream directly the headers may be a nice-to-have

> Still wouldn't mind knowing what caused that? That's a weird failure mode Probably due to the fact you didnt call `HttpSendHeaders` (which caused curl to get *really* confused when it didnt get any data) I think Cytoplasm should be made to warn/auto-send when that happens but you could argue that being able to use the stream directly the headers may be a nice-to-have

tobskep commented

2024-10-11 16:03:29 +00:00

Author

Could be a config feature