Merge pull request 'Pre-emptively free out the key' (#41 ) from lda/Cytoplasm:hashmap-del-leak into master

Reviewed-on: #41
[FIX] Pre-emptively free out the key
2024-08-09 09:26:49 -04:00 · 2024-07-19 16:08:25 +02:00
1 changed files with 2 additions and 0 deletions
--- a/src/HashMap.c
+++ b/src/HashMap.c
@ -184,6 +184,8 @@ HashMapDelete(HashMap * map, const char *key)
        if (bucket->hash == hash)
        {
            bucket->hash = 0;
+            Free(bucket->key);
+            bucket->key = NULL;
            return bucket->value;
        }
Author	SHA1	Message	Date
Jordan Bancino	4903c075e8	Merge pull request 'Pre-emptively free out the key' (#41 ) from lda/Cytoplasm:hashmap-del-leak into master Some checks failed Compile Cytoplasm / Compile Cytoplasm (x86, alpine-v3.19) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86, debian-v12.4) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86, freebsd-v14.0) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86, netbsd-v9.3) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86_64, alpine-v3.19) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86_64, debian-v12.4) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86_64, freebsd-v14.0) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86_64, netbsd-v9.3) (push) Has been cancelled Details Compile Cytoplasm / Compile Cytoplasm (x86_64, openbsd-v7.4) (push) Has been cancelled Details Reviewed-on: #41	2024-08-09 09:26:49 -04:00
LDA	da857a3d53	[FIX] Pre-emptively free out the key I fail to see a reason why this shouldn't be done, to be fair, and it fixes a memory leakage with a Cytoplasm-based project I'm making.	2024-07-19 16:08:25 +02:00