From d7faff734cfc2066ccb820fc4344491077630cb9 Mon Sep 17 00:00:00 2001 From: LDA Date: Sun, 23 Jun 2024 07:52:32 +0200 Subject: [PATCH] [FIX] Actually apply serverName As it turns out, it *was* odd. Not doing that will cause *someone* to spend several hours fixing a SSL problem around a bridge they're making, which needs to download media from a server and can't from *some* for an undiscernable reason, causing said person to start going insane before realising that Cytoplasm didn't set the server name properly. --- src/Tls/TlsOpenSSL.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/Tls/TlsOpenSSL.c b/src/Tls/TlsOpenSSL.c index 8020ec1..a956d2a 100644 --- a/src/Tls/TlsOpenSSL.c +++ b/src/Tls/TlsOpenSSL.c @@ -71,14 +71,6 @@ TlsInitClient(int fd, const char *serverName) OpenSSLCookie *cookie; char errorStr[256]; - /* - * TODO: Seems odd that this isn't needed to make the - * connection... we should figure out how to verify the - * certificate matches the server we think we're - * connecting to. - */ - (void) serverName; - cookie = Malloc(sizeof(OpenSSLCookie)); if (!cookie) { @@ -96,6 +88,7 @@ TlsInitClient(int fd, const char *serverName) } cookie->ssl = SSL_new(cookie->ctx); + SSL_set_tlsext_host_name(cookie->ssl, serverName); if (!cookie->ssl) { goto error;